Bugfix: Playlist view crashes when media list is undefined #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobocop2
commented
Nov 29, 2023
| @@ -98,14 +98,18 @@ export function PlaylistsSelection(props) { | |||
| let ret = []; | |||
| let i = 0; | |||
| while (i < playlists.length) { | |||
There was a problem hiding this comment.
@mgogoulos media_list is undefined for playlists with no media. This causes issues anytime this function is called and makes the playlist functionality non deterministic
tobocop2
force-pushed
the
fix-playlist-creation-bug
branch
from
3c45c02 to
9caa364
Compare
|
tagging for visibility @mgogoulos |
tobocop2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mgogoulos
Description
Playlists with no media cannot be modified. If you create a playlist and do not add media to the playlist, there is a very loud error around the media list being undefined for the playlist. This fix adds some safety checks before attempting to view the playlist.
Steps
Pre-deploy
Post-deploy
Verify that an empty playlist can be modified in the UI.