refactor: megfile sync #491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bbtfr
commented
Jan 25, 2025
•
bbtfr
commented
- 每个文件拷贝完打印一下完成，可以通过 --verbose 开启
- 扫描文件改为在线程里完成，这样可以边扫边拷，对大量小文件比较友好
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 99.98% 99.95% -0.04%
==========================================
Files 44 44
Lines 6391 6409 +18
==========================================
+ Hits 6390 6406 +16
- Misses 1 3 +2 ☔ View full report in Codecov by Sentry. |
bbtfr
force-pushed
the
liyang/megfile-sync-print-more
branch
from
f3c7407 to
a221c73
Compare
bbtfr
commented
Jan 25, 2025
| @@ -69,10 +71,13 @@ def cli(debug, log_level): | |||
|
|
|||
|
|
|||
| def safe_cli(): # pragma: no cover | |||
| debug = options.get("debug", False) | |||
| if not debug: | |||
| signal.signal(signal.SIGINT, signal.SIG_DFL) | |||
There was a problem hiding this comment.
加上这句使得 Ctrl+C 总是能立刻关掉任务
CLI 里有些地方很多地方用了多线程，Ctrl+C 半天关不掉
bbtfr
commented
Jan 25, 2025
| ) | ||
| @click.option("-G", "--no-progress-bar", is_flag=True, help="Do not show progress bar.") |
There was a problem hiding this comment.
这里有个不向前兼容更新，把 --progress-bar 改成 --no-progress-bar
之前这个设成啥都会有进度条，只是有没有 total 的区别，感觉有歧义
bbtfr
commented
Jan 25, 2025
| @@ -404,7 +404,7 @@ def _smart_sync_single_file(items: dict): | |||
| force = items["force"] | |||
| overwrite = items["overwrite"] | |||
|
|
|||
| content_path = os.path.relpath(src_file_path, start=src_root_path) | |||
| content_path = smart_relpath(src_file_path, start=src_root_path) | |||
There was a problem hiding this comment.
这里是个 bugfix，不用 smart_relpath 会导致 alias 拼路径拼错
bbtfr
commented
Jan 25, 2025
| @@ -438,6 +438,8 @@ def _smart_sync_single_file(items: dict): | |||
| callback=copy_callback, | |||
| followlinks=followlinks, | |||
| ) | |||
| elif callback: | |||
| callback(src_file_path, src_file_stat.size) | |||
bbtfr
force-pushed
the
liyang/megfile-sync-print-more
branch
2 times, most recently
from
d1f66bb to
574a659
Compare
bbtfr
force-pushed
the
liyang/megfile-sync-print-more
branch
2 times, most recently
from
ae8c450 to
8f848c4
Compare
bbtfr
force-pushed
the
liyang/megfile-sync-print-more
branch
from
8f848c4 to
8086eb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.