checkpoint as a model config parameter for warmup cosine learning rates #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziw-liu
reviewed
Jan 25, 2024
ziw-liu
approved these changes
Jan 25, 2024
edyoshikun
added a commit
that referenced
this pull request
Jun 12, 2024
…es (#66) * adding chkpt path optional to configfile to use warmup cosine learning rate * fixing the loading of weights * remove additional blank --------- Co-authored-by: Ziwen Liu <[email protected]>
edyoshikun
added a commit
that referenced
this pull request
Jun 12, 2024
…es (#66) * adding chkpt path optional to configfile to use warmup cosine learning rate * fixing the loading of weights * remove additional blank --------- Co-authored-by: Ziwen Liu <[email protected]>
edyoshikun
added a commit
that referenced
this pull request
Jun 12, 2024
…es (#66) * adding chkpt path optional to configfile to use warmup cosine learning rate * fixing the loading of weights * remove additional blank --------- Co-authored-by: Ziwen Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the an extra parameter for the CLI to provide the checkpoint path to be loaded such that is compatible when using warmup cosine learning rates. By default, the lightning CLI has a
ckpt_path, but this loads the previous checkpoint's learning rate as well as the weights. When using the latter option, the re-training for next model starts as a 'sine' function rather than cosine.