Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix some docstring typos and apply refactors suggested by Sourcery #2052

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 17, 2023

Copy link

codspeed-hq bot commented Nov 17, 2023

CodSpeed Performance Report

Merging #2052 will not alter performance

Comparing chore/source-refactors-typos (3fd7bb0) with main (80e31a2)

Summary

✅ 1 untouched benchmarks

@edgarrmondragon edgarrmondragon changed the title chore: Fix some docstring types and apply some refactorings suggested by Sourcery chore: Fix some docstring typos and apply refactors suggested by Sourcery Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (80e31a2) 86.83% compared to head (3fd7bb0) 87.00%.

Files Patch % Lines
singer_sdk/authenticators.py 40.00% 3 Missing ⚠️
singer_sdk/helpers/_state.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2052      +/-   ##
==========================================
+ Coverage   86.83%   87.00%   +0.16%     
==========================================
  Files          58       58              
  Lines        4885     4855      -30     
  Branches      777      764      -13     
==========================================
- Hits         4242     4224      -18     
+ Misses        456      446      -10     
+ Partials      187      185       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 17, 2023 20:08
@edgarrmondragon edgarrmondragon merged commit b8ab97e into main Nov 17, 2023
26 of 27 checks passed
@edgarrmondragon edgarrmondragon deleted the chore/source-refactors-typos branch November 17, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant