-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(targets): Added a class method to instantiate JSONSchemaToSQL
from the target configuration
#2782
Draft
edgarrmondragon
wants to merge
3
commits into
main
Choose a base branch
from
edgarrmondragon/refactor/jsonschematosql-fromconfig
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor(targets): Added a class method to instantiate JSONSchemaToSQL
from the target configuration
#2782
edgarrmondragon
wants to merge
3
commits into
main
from
edgarrmondragon/refactor/jsonschematosql-fromconfig
+46
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CodSpeed Performance ReportMerging #2782 will not alter performanceComparing Summary
|
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/jsonschematosql-fromconfig
branch
from
November 28, 2024 23:23
bc026c7
to
934ef21
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2782 +/- ##
=======================================
Coverage 91.33% 91.34%
=======================================
Files 62 62
Lines 5206 5210 +4
Branches 672 672
=======================================
+ Hits 4755 4759 +4
Misses 319 319
Partials 132 132 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/jsonschematosql-fromconfig
branch
3 times, most recently
from
November 28, 2024 23:48
55b3d2c
to
4be6949
Compare
edgarrmondragon
changed the title
refactor: Added a class method to instantiate
refactor(targets): Added a class method to instantiate Nov 30, 2024
JSONSchemaToSQL
from the tap configurationJSONSchemaToSQL
from the target configuration
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/jsonschematosql-fromconfig
branch
from
November 30, 2024 04:04
4be6949
to
de53f85
Compare
…the tap configuration
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/jsonschematosql-fromconfig
branch
from
November 30, 2024 20:27
de53f85
to
42a702d
Compare
edgarrmondragon
commented
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://meltano-sdk--2782.org.readthedocs.build/en/2782/