-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use public log levels mapping in Python 3.11+ #2850
chore: Use public log levels mapping in Python 3.11+ #2850
Conversation
Reviewer's Guide by SourceryThe pull request updates the logging level mapping in the singer_sdk/plugin_base.py file to use the public API logging.getLevelNamesMapping() for Python 3.11 and above, while maintaining compatibility with older versions by falling back to logging._nameToLevel. This change ensures that the logger method uses the updated log levels mapping. Class diagram showing logger configuration changesclassDiagram
class PluginBase {
-_LOG_LEVELS_MAPPING: dict
+logger(): Logger
}
note for PluginBase "Python 3.11+: Uses public getLevelNamesMapping()
Python <3.11: Uses internal _nameToLevel"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2850 +/- ##
=======================================
Coverage 91.33% 91.34%
=======================================
Files 62 62
Lines 5206 5209 +3
Branches 672 673 +1
=======================================
+ Hits 4755 4758 +3
Misses 319 319
Partials 132 132 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @edgarrmondragon - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
CodSpeed Performance ReportMerging #2850 will not alter performanceComparing Summary
|
Summary by Sourcery
Enhancements:
📚 Documentation preview 📚: https://meltano-sdk--2850.org.readthedocs.build/en/2850/