-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More docs for v1.2 #923
More docs for v1.2 #923
Changes from 7 commits
2eeb21e
01e330e
262a31c
3c11ae9
53a8b68
a16e2c4
c1e023b
684fa5d
379711d
7362714
8c85b6f
4c44322
792bf15
f946fdc
45acb1d
09c3cec
e3b02f9
899b9f7
dca6e27
d25ddcc
d2d25ca
56a72bd
856b0de
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please apply the same changes as in case of |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -45,7 +45,7 @@ defmodule Membrane.Bin.Action do | |||||
|> child(:demuxer, My.Demuxer) | ||||||
|> via_out(:video) | ||||||
|> child(:decoder, My.Decoder) | ||||||
|> child(:ai_filter, My.AI.Filter{mode: :picasso_effect) | ||||||
|> child(:ai_filter, %My.AI.Filter{mode: :picasso_effect}) | ||||||
|> child(:encoder, My.Encoder) | ||||||
|> via_in(:video) | ||||||
|> child(:webrtc_sink, My.WebRTC.Sink) | ||||||
|
@@ -54,7 +54,7 @@ defmodule Membrane.Bin.Action do | |||||
|
||||||
![](assets/images/spec_without_audio.svg) | ||||||
|
||||||
Returning another spec | ||||||
Returning another spec (on top of the previous one) | ||||||
```elixir | ||||||
get_child(:demuxer) | ||||||
|> via_out(:audio) | ||||||
|
@@ -63,7 +63,7 @@ defmodule Membrane.Bin.Action do | |||||
|> get_child(:webrtc_sink) | ||||||
``` | ||||||
|
||||||
will result in having following children topology: | ||||||
will result in having the following children's topology: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
![](assets/images/spec_with_audio.svg) | ||||||
""" | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -38,7 +38,7 @@ defmodule Membrane.Pipeline.Action do | |||||
|> child(:demuxer, My.Demuxer) | ||||||
|> via_out(:video) | ||||||
|> child(:decoder, My.Decoder) | ||||||
|> child(:ai_filter, My.AI.Filter{mode: :picasso_effect) | ||||||
|> child(:ai_filter, %My.AI.Filter{mode: :picasso_effect}) | ||||||
|> child(:encoder, My.Encoder) | ||||||
|> via_in(:video) | ||||||
|> child(:webrtc_sink, My.WebRTC.Sink) | ||||||
|
@@ -47,7 +47,7 @@ defmodule Membrane.Pipeline.Action do | |||||
|
||||||
![](assets/images/spec_without_audio.svg) | ||||||
|
||||||
Returning another spec | ||||||
Returning another spec (on top of the previous one) | ||||||
```elixir | ||||||
get_child(:demuxer) | ||||||
|> via_out(:audio) | ||||||
|
@@ -56,7 +56,7 @@ defmodule Membrane.Pipeline.Action do | |||||
|> get_child(:webrtc_sink) | ||||||
``` | ||||||
|
||||||
will result in having following children topology: | ||||||
will result in having the following children's topology: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, you are right, children is already plural, so it should be |
||||||
|
||||||
![](assets/images/spec_with_audio.svg) | ||||||
""" | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.