Replace RTP.SessionBins with RTP.Muxers and RTP.Demuxers #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noarkhh
changed the title
wkozyra95
reviewed
Jan 15, 2025
examples/mix.exs
Outdated
| @@ -34,9 +34,10 @@ defmodule Membrane.LiveCompositor.Examples.Mixfile do | |||
| # Examples | |||
| {:membrane_file_plugin, "~> 0.17.0"}, | |||
| {:membrane_realtimer_plugin, "~> 0.9.0"}, | |||
| {:membrane_sdl_plugin, "~> 0.18.2"}, | |||
| #{:membrane_sdl_plugin, "~> 0.18.2"}, | |||
| |> via_out(:output, options: [stream_id: {:payload_type, 97}]) | ||
| |> child(%Membrane.RTP.JitterBuffer{latency: 0, clock_rate: 48_000}) | ||
| |> child(RTP.Opus.Depayloader) | ||
| |> child({:output_processor, pad_id}, Membrane.LiveCompositor.AudioOutputProcessor) | ||
| |> bin_output(Pad.ref(:audio_output, pad_id)) |
There was a problem hiding this comment.
I think output_processor for video and audio is no longer necessary after this change. But it is not strictly related to this change, so you can leave if if you want.
There was a problem hiding this comment.
Aren't they still responsible for requesting keyframes?
wkozyra95
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes membraneframework/membrane_core#932