Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send RTMP messages to client handler #103

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Send RTMP messages to client handler #103

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32c2aaa
Send RTMP messages to client handler
lastcanal Oct 29, 2024
6b93283
Start sending RTMP messages after being notified about client
lastcanal Oct 29, 2024
e0d2205
Rename handle_rtmp_message callback into handle_metadata. Invoke this…
varsill Oct 30, 2024
e8db6bc
Merge pull request #1 from membraneframework/add_handle_metadata
lastcanal Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion lib/membrane_rtmp_plugin/rtmp_server/client_handler.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ defmodule Membrane.RTMPServer.ClientHandler do
use GenServer

require Logger
alias Membrane.RTMP.{Handshake, MessageHandler, MessageParser}
alias Membrane.RTMP.{Handshake, MessageHandler, MessageParser, Messages}

@typedoc """
A type representing a module which implements `#{inspect(__MODULE__)}` behaviour.
Expand Down Expand Up @@ -48,12 +48,30 @@ defmodule Membrane.RTMPServer.ClientHandler do
"""
@callback handle_connection_closed(state :: state()) :: state()

@doc """
The optional callback invoked when the client handler receives RTMP message with
metadata information (just like a resolution or a framerate of a video stream).
The following messages are considered the ones that contain metadata:
1) OnMetaData
2) SetDataFrame
"""
@callback handle_metadata(
{:metadata_message, Messages.OnMetaData.t() | Messages.SetDataFrame.t()},
state()
) :: state()

@doc """
The callback invoked when the client handler receives a message
that is not recognized as an internal message of the client handler.
"""
@callback handle_info(msg :: term(), state()) :: state()

@optional_callbacks handle_metadata: 2

defguardp is_metadata_message(message)
when is_struct(message, Messages.OnMetaData) or
is_struct(message, Messages.SetDataFrame)

@doc """
Makes the client handler ask client for the desired number of buffers
"""
Expand Down Expand Up @@ -185,6 +203,24 @@ defmodule Membrane.RTMPServer.ClientHandler do

state = Enum.reduce(events, state, &handle_event/2)

state =
if state.notified_about_client? &&
Kernel.function_exported?(state.handler, :handle_metadata, 2) do
new_handler_state =
Enum.reduce(messages, state.handler_state, fn
{%Membrane.RTMP.Header{}, message}, handler_state
when is_metadata_message(message) ->
state.handler.handle_metadata({:metadata_message, message}, handler_state)

_other, handler_state ->
handler_state
end)

%{state | handler_state: new_handler_state}
else
state
end

request_data(state)

{:noreply,
Expand Down