Add tcp depayloader #161
Add tcp depayloader #161
Conversation
Noarkhh
force-pushed
the
add-tcp-depayloader
branch
2 times, most recently
from
b579d3c to
f250ab7
Compare
Noarkhh
force-pushed
the
add-tcp-depayloader
branch
from
f250ab7 to
07093c9
Compare
Noarkhh
force-pushed
the
add-tcp-depayloader
branch
from
6777b6c to
b321cf0
Compare
Noarkhh
force-pushed
the
add-tcp-depayloader
branch
from
7844264 to
ccfa6d1
Compare
| get_complete_packets(packets_binary, state.rtp_channel_id) | ||
|
|
||
| packets_buffers = | ||
| Enum.map(complete_packets_binaries, &%Buffer{payload: &1, metadata: metadata}) |
There was a problem hiding this comment.
do we have a guarantee that the metadata is rewritten properly? What if the buffer's payload is put in unprocessed_data, and the metadata is attached to the data corresponding to the previous input buffer?
There was a problem hiding this comment.
the only metadata that is in buffers coming from TCP Source are tcp_source_address, tcp_source_port and arrival_ts. The first two don't change and the third one can be interpreted as in when the packet has fully arrived, which then works in this case
There was a problem hiding this comment.
I see, it makes sense, however, I am slightly worried that in case we were about to extend the metadata sent from the TCP Source, we would need to remember that the metadata is translated by one buffer when passed through the depayloader
Co-authored-by: Łukasz Kita <[email protected]>
Co-authored-by: Łukasz Kita <[email protected]>
membraneframework/membrane_core#697
Add an element for depayloading a RTP stream received through TCP and encapsulated according to RFC 7826 Section 14.