Implement elements for packetizing and depacketzing RTP packets for TCP #163
Conversation
wkozyra95
force-pushed
the
@wkozyra95/add-rtp-tcp-packetizer
branch
from
8117047 to
57d18f7
Compare
lib/membrane/rtp/tcp_depacketizer.ex
Outdated
| case :binary.encode_unsigned(byte_size(payload), :big) do | ||
| <<len::size(8)>> -> <<0, len>> | ||
| <<len::binary-size(2)>> -> len | ||
| end |
There was a problem hiding this comment.
This can be replaced with len_bytes = <<byte_size(payload)::size(16)>> (Elixir uses big endian by default when creating binaries this way)
There was a problem hiding this comment.
this can be further expanded to payload = <<byte_size(payload)::size(16), payload::binary>>, which creates the prefixed payload that can be directly passed to outputed buffer
lib/membrane/rtp/tcp_depacketizer.ex
Outdated
| @@ -0,0 +1,48 @@ | |||
| defmodule Membrane.RTP.TCP.Depacketizer do | |||
There was a problem hiding this comment.
It was kind of counterintuitive to me that Depacketizer is reponsible for encapsulation, even though it technically is correct. What do you think about Encapsulator and Decapsulator?
There was a problem hiding this comment.
Personally, I would probably stay with Packetizer/Depacketizer or Payloader/Depayloader, but I don't mind changing that
There was a problem hiding this comment.
Hmm, actually is it correct? I think of depacketizing as of getting out of packets, which in this case would be removing the two-byte header with packet length…
There was a problem hiding this comment.
the RFC calls it framing: https://datatracker.ietf.org/doc/html/rfc4571 however as I read it, I understand that by framing they mean adding the 2 byte header, not the other way
There was a problem hiding this comment.
packetizing = converting to packets from a continuous stream of data (TCP does not really have a concept of packets)
I already changed it either way so does not really matter
lib/membrane/rtp/tcp_packetizer.ex
Outdated
| end | ||
|
|
||
| defp get_complete_packets(packets_binary, complete_packets) do | ||
| <<payload_length::size(16), rest::binary>> = packets_binary |
There was a problem hiding this comment.
you can change the function headers to the following:
defp get_complete_packets(
<<payload_length::16, payload::binary-size(payload_length), rest::binary>>,
complete_packets) do
# next chunk available
end
defp get_complete_packets(leftover, complete_packets) do
# next chunk unavailable
end
wkozyra95
force-pushed
the
@wkozyra95/add-rtp-tcp-packetizer
branch
from
df8fd3a to
8c507a0
Compare
…connection-oriented transport
wkozyra95
force-pushed
the
@wkozyra95/add-rtp-tcp-packetizer
branch
from
8c507a0 to
273e719
Compare
Membrane.RTP.TCP.Encapsulator- reads packet and generates bytestream that can be send over connection-oriented transport (such as TCP)Membrane.RTP.TCP.Decapsulator- create RTP packets from a bytestreamMostly based on
Membrane.RTP.TCP.Depayloader(this element implements different mechanism used in RTSP)I'm open to the name suggestions:
Membrane.RTP.TCP.DepayloaderandMembrane.RTP.TCP.Payloader, but in that case existingMembrane.RTP.TCP.Depayloaderwould need to be renamed