Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small corrections for Bin and Dynamic Pads code examples #94

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Small corrections for Bin and Dynamic Pads code examples #94

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c03c41c
small changes to the code samples
drewknab Jun 6, 2024
b632779
Correction based on review comments
drewknab Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion basic_pipeline_extension/02_Bin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ defmodule Basic.Bin do
spec = [
child(:input, %Basic.Elements.Source{location: options.input_filename})
|> child(:ordering_buffer, Basic.Elements.OrderingBuffer)
|> to(:depayloader, %Basic.Elements.Depayloader{packets_per_frame: 4})
|> child(:depayloader, %Basic.Elements.Depayloader{packets_per_frame: 4})
|> bin_output(:output)
]

Expand Down
2 changes: 0 additions & 2 deletions basic_pipeline_extension/03_DynamicPads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ The very first thing we need to do is to use the `def_input_pads` appropriately.
```elixir
...
def_input_pad :input,
demand_unit: :buffers,
flow_control: :pull,
Copy link
Member

@FelonEkonom FelonEkonom Jun 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flow_control: :pull with demand_mode: :manual (the old default) became flow_control: :manual
flow_control: :pull with demand_mode: :auto became flow_control: :auto (the new default)

Input pads with flow_control: :manual always have to specify demand_unit explicitly

Suggested change
demand_unit: :buffers,
flow_control: :pull,
demand_unit: :buffers,
flow_control: :manual,

availability: :on_request,
accepted_format: %Basic.Formats.Frame{encoding: :utf8}
...
Expand Down
Loading