Allow for specifying target bitrate in options #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
requested changes
Jul 24, 2024
Comment on lines
30
to
38
| target_bitrate: [ | ||
| spec: pos_integer(), | ||
| default: 1000, | ||
| description: """ | ||
| Gives the encoder information about the target bitrate (in kb/s). | ||
| """ |
There was a problem hiding this comment.
Please put here some examples, what range of values is reasonable for a video with 2560 x 1440, 1280 x 720 or 640 x 360, to give an impression, what bitrate value is low for a specific video size and what bitrate is high.
Do it here and in VP8 Encoder.
Beyond this, I think that default: 1000 is not a good idea - it will cause having a good video quality, when the video size is small and bad video quality, when the video size is too big. Default bitrate may vary depending on the size of the input video.
FelonEkonom
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Please, ensure that your PR fixes membraneframework/membrane_core#841, bump the version and release the plugin
varsill
approved these changes
Jul 31, 2024
Noarkhh
force-pushed
the
bitrate-option
branch
2 times, most recently
from
9e5fa2e to
fee2753
Compare
This reverts commit a5396a4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.