Added pre-commit hooks and linters #49
Conversation
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
| @@ -1 +1,3 @@ | |||
| scripts | |||
| node_modules | |||
There was a problem hiding this comment.
Why do we need these ignores?
There was a problem hiding this comment.
For packages of husky
.pre-commit-config.yaml
Outdated
| hooks: | ||
| - id: prettier-staged | ||
| name: Prettier Staged | ||
| entry: git-format-staged -f 'prettier --ignore-unknown --stdin --stdin-filepath "$FILENAME"' |
There was a problem hiding this comment.
Does this require each contributor to install git-format-staged and prettier on their local machine in advance?
There was a problem hiding this comment.
Should I mention it in the README under Contributing?
There was a problem hiding this comment.
Hi，I would like to confirm, after having this PR, if the developer clones the repository, can he directly git commit the code without performing any additional operations?
There was a problem hiding this comment.
I added installation command for it in the latest commit
There was a problem hiding this comment.
Yes, with the update he can
|
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀 |
Please review for any changes
Closes #48