-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed the linting for NextJS project using husky #54
Conversation
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
@ahaapple Now you can check it, this one is better and suits a NextJS repo. |
On it |
@ahaapple I have done the necessary changes, please review now |
|
I think a more elegant solution may be to use GitHub Actions to check each PR to be merged. Developers can use VScode to solve TS checks, code quality checks, and code formatting during the development process. We only need to check once before merging the PR. The benefits of this are: 1 Developers do not need to perform additional operations locally, which is more developer-friendly |
Ok, I'll discard the husky and add it to GitHub Actions |
seems we need to update the node version:
|
@ahaapple Basically its performing linting and prettier check for the frontend directory |
@sank8-2 Thanks for your contribution. I think the current actions are enough. When we have enough test cases, we can add the check action of |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀 |
@ahaapple Ok |
Added husky, lint for nextjs and prettier for code formatting
How to setup
Run
npm i
from the root directory, all packages and linters gets installed and setup in the localThen it runs automatically at every commit without extra configuration.
Closes #51