-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "Open in App" button to website #21
Conversation
for externally-triggered opening of packages in the GUI application.
Related to a discussion in memo33/sc4pac/issues/49. @sebamarynissen |
I started working on a browser plugin as mentionned here. I'm waiting for this to complete to implement the same feature. Related to memo33/sc4pac-gui#13. |
Could you release a snapshot with this feature so I can test it out? |
Sure. I'm going to create a proper release then, as the change to the website would depend on it.
|
This is preliminary experimental support for displaying channel-external packages on the website. See #21
I've just released version 0.2.1 of the GUI and 0.5.1 of the CLI. Two remarks:
|
This adds a button to the website to open a package in the GUI.
The GUI must already be running (on the default port 51515), as the button sends a POST request to the API.
This is a cross-platform solution that avoids registering a custom URI scheme. A custom scheme handler could maybe still be added in the future for Windows and Linux, which would launch the native GUI application.
With this approach, external websites could link to the package page on
https://memo33.github.io/sc4pac
instead of linking to the GUI directly.A remaining open question at this point is whether each channel is going to get its own website, or whether packages from other channels would be displayed on the main website, using URLs such as: