Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "Open in App" button to website #21

Merged
merged 3 commits into from
Dec 21, 2024
Merged

add "Open in App" button to website #21

merged 3 commits into from
Dec 21, 2024

Conversation

memo33
Copy link
Owner

@memo33 memo33 commented Dec 18, 2024

This adds a button to the website to open a package in the GUI.

The GUI must already be running (on the default port 51515), as the button sends a POST request to the API.

This is a cross-platform solution that avoids registering a custom URI scheme. A custom scheme handler could maybe still be added in the future for Windows and Linux, which would launch the native GUI application.

With this approach, external websites could link to the package page on https://memo33.github.io/sc4pac instead of linking to the GUI directly.

2024-12-18_21 50 02

A remaining open question at this point is whether each channel is going to get its own website, or whether packages from other channels would be displayed on the main website, using URLs such as:

https://memo33.github.io/sc4pac/channel/?pkg=jasoncw:elks-building&channel=https://zasco.github.io/sc4pac-channel/channel/

for externally-triggered opening of packages in the GUI application.
@memo33
Copy link
Owner Author

memo33 commented Dec 18, 2024

Related to a discussion in memo33/sc4pac/issues/49. @sebamarynissen

@Zasco
Copy link
Contributor

Zasco commented Dec 19, 2024

I started working on a browser plugin as mentionned here. I'm waiting for this to complete to implement the same feature. Related to memo33/sc4pac-gui#13.

@memo33 memo33 merged commit 0fd6605 into api Dec 21, 2024
2 checks passed
@Zasco
Copy link
Contributor

Zasco commented Dec 24, 2024

I started working on a browser plugin as mentionned here. I'm waiting for this to complete to implement the same feature. Related to memo33/sc4pac-gui#13.

Could you release a snapshot with this feature so I can test it out?

@memo33
Copy link
Owner Author

memo33 commented Dec 26, 2024 via email

memo33 added a commit that referenced this pull request Dec 26, 2024
This is preliminary experimental support for displaying channel-external
packages on the website.

See #21
memo33 added a commit to memo33/sc4pac-gui that referenced this pull request Dec 26, 2024
@memo33
Copy link
Owner Author

memo33 commented Dec 26, 2024

I've just released version 0.2.1 of the GUI and 0.5.1 of the CLI. Two remarks:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants