fix: retry polling on all errors #1730
Conversation
|
@danielskinstad, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". my commands and optionsYou can trigger a pipeline on multiple prs with:
You can start a fast pipeline, disabling full integration tests with:
You can trigger GitHub->GitLab branch sync with:
You can cherry pick to a given branch or branches with:
|
There was a problem hiding this comment.
The code looks good 👍
Changelog: All errors when polling for deployment or submitting inventory are retried with an exponential backoff.
To the changelog I would:
- Rephrase a bit to align with the documentation All attempts to communicate with the server are retried on errors ...
- Add a final sense like "This aligns the behavior to the Mender Client 3 state machine"
When implementing the backoff for errors when polling for deployment or submitting inventory, we added an exception for unauthorized errors. After looking at how it was done in Mender Client 3, we discovered that such an exception was not present there, and that the backoff should be triggered for all types of errors. Changelog: All errors on attempts to communicate with the server are retried with an exponential backoff. This aligns the behavior of the state machine with Mender Client 3. Ticket: MEN-7938 Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
danielskinstad
force-pushed
the
retry-mechanism-fix
branch
from
3b7b67f to
45f88a1
Compare
|
Merging these commits will result in the following changelog entries: Changelogsmender (retry-mechanism-fix)New changes in mender since master: Bug Fixes
|
|
@mender-test-bot start pipeline |
|
Hello 😺 I created a pipeline for you here: Pipeline-1635590900 Build Configuration Matrix
|
|
Hello 😺 This PR contains changelog entries. Please, verify the need of backporting it to the following release branches: |
|
I guess the cherry-pick to 5.0.x can wait until the current one is merged |
When implementing the backoff for errors when polling for deployment or submitting inventory, we added an exception for unauthorized errors. After looking at how it was done in Mender Client 3, we discovered that such an exception was not present there, and that the backoff should be triggered for all types of errors.
Changelog: All errors when polling for deployment or submitting inventory are retried with an exponential backoff.
Ticket: MEN-7938