fix: match pattern file with Meshery Design schema #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: weilirs <[email protected]>
leecalcote
requested changes
Jan 10, 2025
There was a problem hiding this comment.
@weilirs how was this design created?
Change the title from "Untitled Design".
When I import this design into a Meshery Server, its validation fails with a missing property.
|
As you work through this, please confirm that the design is deployable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#173 (comment)
This PR fixes this issue
Notes for Reviewers
Followed the instructions from Pranav, exported a design file with a cilium component from Kanvas and replaced the content of it with the existing
deploy.yamlhttps://layer5io.slack.com/archives/C017NA80S66/p1736126652434049?thread_ts=1736126645.139429&cid=C017NA80S66
Signed commits