Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Adapter Library to v0.7.0 #655

Closed
wants to merge 1 commit into from

Conversation

leecalcote
Copy link
Member

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Lee Calcote <[email protected]>
Copy link
Contributor

@singh1203 singh1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nil can be removed in err = grpc.Start(service, nil) for failing tests, or maybe I can open a new PR for it afterwards. Otherwise, LGTM.

@MUzairS15
Copy link

MUzairS15 commented Feb 16, 2024

Upgraded in a separate PR already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants