Upgrade to Go 1.23 #575 #579
Conversation
|
@devhindo Just Added a Condition regarding Go version |
Makefile
Outdated
| @@ -121,6 +121,8 @@ test: manifests generate fmt vet ## Run tests. | |||
|
|
|||
| ##@ Build | |||
|
|
|||
| +GO_VERSION ?= 1.23 | |||
There was a problem hiding this comment.
@Swastik-Swarup-Dash did you incorporate this feedback? Be sure to reply here...
Makefile
Outdated
| @@ -121,6 +121,8 @@ test: manifests generate fmt vet ## Run tests. | |||
|
|
|||
| ##@ Build | |||
|
|
|||
| +GO_VERSION ?= 1.23 | |||
| +export GO_VERSION | |||
There was a problem hiding this comment.
this shouldn't be added as well
There was a problem hiding this comment.
@Swastik-Swarup-Dash did you incorporate this feedback? Be sure to reply here...
There was a problem hiding this comment.
Yes i have @leecalcote
Signed-off-by: Swastik Swarup Dash <[email protected]>
Swastik-Swarup-Dash
force-pushed
the
go-up
branch
from
919cc87 to
c3f1f8c
Compare
Signed-off-by: Swastik Swarup Dash <[email protected]>
|
@devhindo I think there is an Issue in Signing-off is there any alternative way to proceed |
|
Thank you for contributing to the Layer5 community! 🎉 \ \ |
|
Thanks, @Swastik-Swarup-Dash. Meshery Operator no longer seems to build successfully. Will you verify? |
|
@Swastik-Swarup-Dash https://layer5io.slack.com/archives/C055L65AB99/p1736827137315759... are you in the community Slack? |
yes i am |
I would love to but I am currently busy with a Ongoing Project. |
Signed-off-by: Swastik Swarup Dash [email protected]
Go 1.21 -> Go 1.23