Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial implementation of adding nodes to favorites #1520

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Kealper
Copy link

@Kealper Kealper commented Jan 3, 2025

Initial implementation of support for favorite nodes. Adds support for and closes #1011

I've tested this in the simulator while it was connected to a real node and it seems to work as you'd expect, but it'll need a second pair of eyes on it because I'm not familiar with Kotlin and this is my first time working with it.

@andrekir
Copy link
Member

andrekir commented Jan 3, 2025

Thanks for your contribution! We're in the process of moving some of the NodeMenu items to the node details screen, as it is getting too crowded. Once #1517 is merged we'll revisit this.

@Robert-0410
Copy link
Contributor

Nice one.

@Kealper
Copy link
Author

Kealper commented Jan 3, 2025

Thanks for your contribution! We're in the process of moving some of the NodeMenu items to the node details screen, as it is getting too crowded. Once #1517 is merged we'll revisit this.

Sounds good! Once that commit is in, I'll migrate this to the new spot.

Copy link
Contributor

@jamesarich jamesarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for a Android/Kotlin first-timer! Thanks for dipping your toes in, always happy to have more help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Favorite Nodes in Android
4 participants