Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create new app for Gateway API #3057

Merged
merged 34 commits into from
Jan 31, 2025
Merged

feat: Create new app for Gateway API #3057

merged 34 commits into from
Jan 31, 2025

Conversation

shubham2g
Copy link
Contributor

What problem does this PR solve?:
Add dedicated app for Gateway API CRDs

Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-105328

@shubham2g shubham2g self-assigned this Jan 24, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. services/traefik labels Jan 24, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 24, 2025
@coveralls
Copy link

coveralls commented Jan 24, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13071348660

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 13051681585: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

@shubham2g shubham2g force-pushed the Shubham/Gateway-API-App branch from ce76e34 to 89ec410 Compare January 24, 2025 11:35
@shubham2g shubham2g force-pushed the Shubham/Gateway-API-App branch from 7a49d06 to 8b68156 Compare January 24, 2025 11:50
@shubham2g shubham2g added ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review and removed ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Jan 24, 2025
@shubham2g shubham2g force-pushed the Shubham/Gateway-API-App branch from 40b56ea to 4085279 Compare January 24, 2025 12:12
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 27, 2025
@github-actions github-actions bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2025
@github-actions github-actions bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 30, 2025
@github-actions github-actions bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2025
@shubham2g shubham2g added ok-to-test Signals mergebot that CI checks are ready to be kicked off and removed ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Jan 30, 2025
@shubham2g shubham2g force-pushed the Shubham/Gateway-API-App branch from bc0b780 to 158056a Compare January 30, 2025 15:33
@shubham2g shubham2g added open-kommander-pr Automatically triggers the creation of a PR in Kommander repo and removed open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/Shubham/Gateway-API-App

@mhrabovcin mhrabovcin merged commit 6b63047 into main Jan 31, 2025
30 checks passed
@mhrabovcin mhrabovcin deleted the Shubham/Gateway-API-App branch January 31, 2025 11:03
rohitkumar0510 pushed a commit that referenced this pull request Feb 5, 2025
@shubham2g @d2iq-mergebot
@mhrabovcin @rohitkumar0510
feat: Create new app for Gateway API (#3057)
c0275d1 
* feat: Create new app for Gateway API

* feat: Create new app for Gateway API

* feat: Work on comment

* feat: api version correction

* build: Updated .github/service-labeler.yaml

* feat: api version correction

* feat: Add independent management of Traefik CRDs

* feat: update kustomization.yaml

* feat: worked on comment

* feat: include list-images-values.yaml

* feat: update the dir structure

* feat: worked on comment

* feat: kustomization file update

* feat: kustomization file update

* feat: apiversion update

* feat: changed the logic in apptests

* feat: skip crds installtion

* feat: Add CRDs installation in apptests

* feat: Add traefik crd as dependency

* feat: used absolutepath function

* feat: corrected gateway api path

* feat: Added default CM

* feat: path correction

* feat: print path to check

* feat: corrected path

* feat: worked on comment

* feat: changed the name as per comment

* fix(harbor): add gateway-api-crds default app

* fix: add gateway-api-crds metadata

* fix: install gateway-api crds on new version

* fix: avoid adding same traefik override

* fix: trigger reconciliation

* fix: increse wait interval

---------

Co-authored-by: d2iq-mergebot <[email protected]>
Co-authored-by: Martin Hrabovcin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhrabovcin mhrabovcin mhrabovcin approved these changes

Assignees

@shubham2g shubham2g

Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo ready-for-review services/gateway-api-crds services/kommander services/traefik size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shubham2g @coveralls @mhrabovcin @mesosphere-ci @d2iq-mergebot