Skip to content

feat: add options for SSR and SSG #2

feat: add options for SSR and SSG

feat: add options for SSR and SSG #2

Triggered via pull request August 16, 2024 01:44
Status Success
Total duration 37s
Artifacts

clippy.yml

on: pull_request
clippy_check
27s
clippy_check
Fit to window
Zoom out
Zoom in

Annotations

8 warnings
associated function `new` is never used: crates/metassr-build/src/server/render_exec.rs#L59
warning: associated function `new` is never used --> crates/metassr-build/src/server/render_exec.rs:59:12 | 58 | impl MultiRenderExec { | -------------------- associated function in this implementation 59 | pub fn new(files: HashMap<String, i64>) -> Result<Self> { | ^^^
associated items `new` and `generate` are never used: crates/metassr-build/src/server/pages_generator.rs#L29
warning: associated items `new` and `generate` are never used --> crates/metassr-build/src/server/pages_generator.rs:29:12 | 28 | impl PagesGenerator { | ------------------- associated items in this implementation 29 | pub fn new<S: AsRef<OsStr> + ?Sized>( | ^^^ ... 49 | pub fn generate(&self) -> Result<()> { | ^^^^^^^^
struct `PagesGenerator` is never constructed: crates/metassr-build/src/server/pages_generator.rs#L21
warning: struct `PagesGenerator` is never constructed --> crates/metassr-build/src/server/pages_generator.rs:21:12 | 21 | pub struct PagesGenerator { | ^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
you should consider adding a `Default` implementation for `Rand`: crates/metassr-utils/src/rand.rs#L11
warning: you should consider adding a `Default` implementation for `Rand` --> crates/metassr-utils/src/rand.rs:11:5 | 11 | / pub fn new() -> Self { 12 | | let val = RandomState::new().build_hasher().finish() as i64; 13 | | Self(val.abs()) 14 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 10 + impl Default for Rand { 11 + fn default() -> Self { 12 + Self::new() 13 + } 14 + } |
methods called `new` usually return `Self`: crates/html-generator/src/html_props.rs#L17
warning: methods called `new` usually return `Self` --> crates/html-generator/src/html_props.rs:17:5 | 17 | / pub fn new() -> HtmlPropsBuilder { 18 | | HtmlPropsBuilder::new() 19 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self = note: `#[warn(clippy::new_ret_no_self)]` on by default
direct implementation of `ToString`: crates/html-generator/src/builder.rs#L26
warning: direct implementation of `ToString` --> crates/html-generator/src/builder.rs:26:1 | 26 | / impl ToString for HtmlOutput { 27 | | fn to_string(&self) -> String { 28 | | self.0.clone() 29 | | } 30 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl = note: `#[warn(clippy::to_string_trait_impl)]` on by default
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy_check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/