Add fix variations of mf runner examples #598 #662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse all fix workflows from #654 and bring folders together as suggested by @blackwinter in #654 (comment)
blackwinter
requested changes
Feb 4, 2025
There was a problem hiding this comment.
I would have preferred to keep the formatting of the Morph Flux files (would have made diffing easier). The cleanup could be a separate step.
Also, the formatting of the Fix transformation files is all over the place...
P.S.: Should metafacture-runner/src/main/dist/examples/count/metrics/metrics-gnd-subjects.flux maybe also include the morph marker (even though it doesn't have a fix counterpart)?
metafacture-runner/src/main/dist/examples/beacon/create/create_fix.flux
Outdated
Show resolved
Hide resolved
metafacture-runner/src/main/dist/examples/beacon/create/create_morph.flux
Outdated
Show resolved
Hide resolved
metafacture-runner/src/main/dist/examples/filter/filter-morph.xml
Outdated
Show resolved
Hide resolved
metafacture-runner/src/main/dist/examples/gnd/gnd-and-beacons/tp2index_morph.flux
Outdated
Show resolved
Hide resolved
metafacture-runner/src/main/dist/examples/marc21-to-edm/MARC21-EDM_fix.flux
Show resolved
Hide resolved
metafacture-runner/src/main/dist/examples/transform/pica-to-marcxml/pica-to-marcxml_fix.flux
Show resolved
Hide resolved
metafacture-runner/src/main/dist/examples/transform/pica-to-marcxml/pica-to-marcxml_fix.flux
Show resolved
Hide resolved
metafacture-runner/src/main/dist/examples/transform/pica-to-marcxml/pica-to-marcxml_fix.flux
Show resolved
Hide resolved
metafacture-runner/src/main/dist/examples/transform/marc21/morph-marc21_fix.flux
Outdated
Show resolved
Hide resolved
metafacture-runner/src/main/dist/examples/sort/sort-gnd_fix.flux
Outdated
Show resolved
Hide resolved
TobiasNx
force-pushed
the
589-fixRunnerExamplesNew
branch
from
a2463d3 to
32bfc99
Compare
|
Okay, thanks a lot for the vigirous review. I tried to rearrange the naming and bring back the old formatting. But this did not work. I will open a third PR which the formating, simple errors and naming adjustments. And in additional steps I will check your functional/code review. |
TobiasNx
added a commit
that referenced
this pull request
Feb 5, 2025
Reuse all fix workflows from #654 and bring folders together as suggested by @blackwinter in #654 (comment) and in #662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse all fix workflows from #654 and bring folders together as suggested by @blackwinter in #654 (comment)
If good it would replace #654