More precise logs to understand failure

Signed-off-by: Muhammad Adil Ghaffar <[email protected]>
metal3-io · Jan 24, 2025 · bdeeef6 · bdeeef6
1 parent 7aaf7b8
commit bdeeef6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/api/v1beta1/metal3cluster_webhook.go b/api/v1beta1/metal3cluster_webhook.go
@@ -96,7 +96,7 @@ func (c *Metal3Cluster) validate(oldM3C *Metal3Cluster) error {
 					field.Invalid(
 						field.NewPath("spec", "cloudProviderEnabled"),
 						c.Spec.CloudProviderEnabled,
-						"cloudProviderEnabled conflicts the value of noCloudProvider",
+						"ValidateUpdate failed, cloudProviderEnabled conflicts the value of noCloudProvider",
 					),
 				)
 			}
@@ -110,7 +110,7 @@ func (c *Metal3Cluster) validate(oldM3C *Metal3Cluster) error {
 					field.Invalid(
 						field.NewPath("spec", "noCloudProvider"),
 						c.Spec.NoCloudProvider,
-						"noCloudProvider conflicts the value of cloudProviderEnabled",
+						"ValidateUpdate failed, noCloudProvider conflicts the value of cloudProviderEnabled",
 					),
 				)
 			}

diff --git a/api/v1beta1/metal3cluster_webhook_test.go b/api/v1beta1/metal3cluster_webhook_test.go
@@ -111,7 +111,7 @@ func TestMetal3ClusterValidation(t *testing.T) {
 						Host: "abc.com",
 						Port: 443,
 					},
-					NoCloudProvider: ptr.To(false),
+					NoCloudProvider: ptr.To(true),
 				},
 			},
 			oldCluster: valid,