📖 Commit signing off update. #1309
Conversation
metal3-io-bot
added
the
size/S
adilGhaffarDev
force-pushed
the
dco-guide/adil
branch
2 times, most recently
from
e320a5c to
a6bee9d
Compare
| ### Git commit Sign-off | ||
|
|
||
| This line should be included at the bottom of git commit message. | ||
|
|
There was a problem hiding this comment.
Can you please rewrite the line? You can have something like this or just rephrase it: “Commit message should contain signed off section with full name and email. For example:”
There was a problem hiding this comment.
Otherwise it sounds like John Doe should be the fixed name
Signed-off-by: muhammad adil ghaffar <[email protected]>
adilGhaffarDev
force-pushed
the
dco-guide/adil
branch
from
a6bee9d to
9bb2412
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/lgtm |
|
/override test-ubuntu-integration-main |
|
@lentzi90: Overrode contexts on behalf of lentzi90: test-centos-e2e-integration-main, test-ubuntu-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Updating contributing guide regarding signing off of commits