Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Simplifying and updating clusterctl upgrade tests #1465

Conversation

adilGhaffarDev
Copy link
Member

What this PR does / why we need it:
Simplifying and updating clusterctl upgrade tests
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 21, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-upgradde-v1.5/adil branch from f3a9dc0 to 110ceb7 Compare March 28, 2024 10:55
@adilGhaffarDev adilGhaffarDev changed the title [wip]🌱 Simplifying and updating clusterctl upgrade tests 🌱 Simplifying and updating clusterctl upgrade tests Mar 28, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-5

@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-upgradde-v1.5/adil branch from 110ceb7 to 7466163 Compare March 28, 2024 11:48
@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-5

1 similar comment
@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-5

@adilGhaffarDev adilGhaffarDev force-pushed the fix-clusterctl-upgradde-v1.5/adil branch from 7466163 to 1fd75a1 Compare March 28, 2024 12:40
@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-5

1 similar comment
@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-5

@tuminoid
Copy link
Member

tuminoid commented Apr 2, 2024

/test-ubuntu-e2e-integration-release-1-5

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@metal3-io-bot metal3-io-bot merged commit 2ac6b9e into metal3-io:release-1.5 Apr 2, 2024
13 checks passed
@metal3-io-bot metal3-io-bot deleted the fix-clusterctl-upgradde-v1.5/adil branch April 2, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants