Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump CAPI to v1.5.6 #1468

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

adilGhaffarDev
Copy link
Member

What this PR does / why we need it:
as title
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 23, 2024
@kashifest
Copy link
Member

/retitle 🌱 Bump CAPI to v1.5.6
/approve

@metal3-io-bot metal3-io-bot changed the title 🌱 Bumping CAPI to v1.5.6 and syncing go modues with CAPI 🌱 Bump CAPI to v1.5.6 Feb 26, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@kashifest
Copy link
Member

/test-ubuntu-e2e-integration-release-1-5

1 similar comment
@kashifest
Copy link
Member

/test-ubuntu-e2e-integration-release-1-5

@kashifest
Copy link
Member

Now this is failing because for release-1.5 PR we export the CAPM3BRANCH var as the PR commit hash, hence this check doesnt hold. Perhaps we should use CAPM3RELEASEBRANCH instead in dev-env.

@kashifest
Copy link
Member

/test-ubuntu-e2e-integration-release-1-5

@kashifest
Copy link
Member

Now this is failing because for release-1.5 PR we export the CAPM3BRANCH var as the PR commit hash, hence this check doesnt hold. Perhaps we should use CAPM3RELEASEBRANCH instead in dev-env.

The fix has landed and the new test moved forward. Now the failure is more related to your change, you have bumped envsubst to use v2 but somewhere (probably in Makefile) envsubst (v1) is still expected, you might need to change that as well. Here is the error

rm -f hack/tools/bin/envsubst*
11:31:21  cd hack/tools && go build -tags=tools -o bin/envsubst-drone github.com/drone/envsubst/cmd/envsubst
11:31:21  no required module provides package github.com/drone/envsubst/cmd/envsubst; to add it:
11:31:21  	go get github.com/drone/envsubst/cmd/envsubst
11:31:21  make[1]: *** [Makefile:259: hack/tools/bin/envsubst-drone] Error 1

@adilGhaffarDev
Copy link
Member Author

The fix has landed and the new test moved forward. Now the failure is more related to your change, you have bumped envsubst to use v2 but somewhere (probably in Makefile) envsubst (v1) is still expected, you might need to change that as well. Here is the error

Fixing it.

@adilGhaffarDev
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-5

1 similar comment
@adilGhaffarDev
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-5

@adilGhaffarDev
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-5

1 similar comment
@adilGhaffarDev
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-5

@kashifest
Copy link
Member

/cc @lentzi90 @mboukhalfa

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@metal3-io-bot metal3-io-bot merged commit cb93d3b into metal3-io:release-1.5 Feb 29, 2024
16 checks passed
@metal3-io-bot metal3-io-bot deleted the bump-capi-1.5.6/adil branch February 29, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants