-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump CAPI to v1.8.1 #1889
🌱 Bump CAPI to v1.8.1 #1889
Conversation
Signed-off-by: Sunnatillo <[email protected]>
bc580cb
to
8c3d64c
Compare
/test metal3-centos-e2e-integration-test-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
can you add in pr description part of #1887 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
--control-plane kubeadm:v1.8.0 -v5 | ||
clusterctl init --core cluster-api:v1.8.1 \ | ||
--bootstrap kubeadm:v1.8.1 \ | ||
--control-plane kubeadm:v1.8.1 -v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we decided not to touch these README for patch releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not remember. But why?
IMHO if we do not change every time, we most likely forget to update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It prevents dependabot from doing these bumps as it cannot handle README.md
README doesn't need to update all the time, so bump once when bumpign minor and then leave alone and let bot do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted. Next time I will not update it.
/lgtm |
Uplifts CAPI to v1.8.1
Part of: #1887