Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump k8s to v.1.32.0 and CAPI to v1.9.1 #2158

Merged
merged 1 commit into from
Dec 18, 2024
Merged

🌱 Bump k8s to v.1.32.0 and CAPI to v1.9.1 #2158

merged 1 commit into from
Dec 18, 2024

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Dec 13, 2024 •
edited by adilGhaffarDev
Loading

What this PR does / why we need it: Bump k8s to v.1.32.0 and CAPI to v1.9.1

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 13, 2024
@peppi-lotta
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

lentzi90
lentzi90 reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
kashifest
kashifest reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
@adilGhaffarDev
Copy link
Member

/retest

@tuminoid
Copy link
Member

Rebase needed to get fixed links.

@adilGhaffarDev
Copy link
Member

Rebase needed to get fixed links.

Since @peppi-lotta is away I will rebase

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@tuminoid
Copy link
Member

/retest

@adilGhaffarDev
Copy link
Member

/hold
lets wait for image building job to pass.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2024
@adilGhaffarDev
Copy link
Member

now images are in artifactory, lets unhold and run tests
/unhold
/retest

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@tuminoid
Copy link
Member

Just noting that CAPI does not have 1.32 yet, so we should not merge this before we can bump CAPI to a version that has the support? It is expected today anyways.

@adilGhaffarDev
Copy link
Member

Just noting that CAPI does not have 1.32 yet, so we should not merge this before we can bump CAPI to a version that has the support? It is expected today anyways.

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2024
@adilGhaffarDev adilGhaffarDev changed the title 🌱 Bump k8s to v.1.32.0 🌱 Bump k8s to v.1.32.0 and CAPI to 1.9.1 Dec 18, 2024
@adilGhaffarDev adilGhaffarDev changed the title 🌱 Bump k8s to v.1.32.0 and CAPI to 1.9.1 🌱 Bump k8s to v.1.32.0 and CAPI to v1.9.1 Dec 18, 2024
@adilGhaffarDev
Copy link
Member

uplifted capi to v1.9.1 which supports k8s v1.32 , we can merge this now
/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

1 similar comment
@kashifest
Copy link
Member

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@kashifest
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
tuminoid
tuminoid reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing README updates
/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@peppi-lotta @adilGhaffarDev
Bump k8s to v.1.32.0
52fd08d 
Signed-off-by: Peppi-Lotta <[email protected]>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@adilGhaffarDev
Copy link
Member

Missing README updates

done

tuminoid
tuminoid reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

/retest
Network flake

@tuminoid
Copy link
Member

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@metal3-io-bot metal3-io-bot merged commit 6711ff3 into metal3-io:main Dec 18, 2024
18 checks passed
@metal3-io-bot metal3-io-bot deleted the bump-k8s-to-1.32.0 branch December 18, 2024 08:49
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.9 milestone Dec 18, 2024
@adilGhaffarDev adilGhaffarDev mentioned this pull request Dec 19, 2024
Open
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@tuminoid tuminoid tuminoid left review comments

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

@Sunnatillo Sunnatillo Awaiting requested review from Sunnatillo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
CAPM3 - v1.9
Development

Successfully merging this pull request may close these issues.
6 participants
@peppi-lotta @metal3-io-bot @adilGhaffarDev @tuminoid @kashifest @lentzi90