Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump github.com/metal3-io/cluster-api-provider-metal3/api from 1.9.0 to 1.9.1 in /hack/fake-apiserver #2222

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 8, 2025

Bumps github.com/metal3-io/cluster-api-provider-metal3/api from 1.9.0 to 1.9.1.

Release notes

Sourced from github.com/metal3-io/cluster-api-provider-metal3/api's releases.

v1.9.1

Changes since v1.9.0

📖 Documentation

  • update build badges and triggers in README.md (#2185)

🌱 Others

  • Bump ipam to 1.9.2 (#2215)
  • Remove CP scaling from e2e-feature-test (#2213)
  • Bump github.com/onsi/ginkgo/v2 from 2.22.1 to 2.22.2 in /test (#2208)
  • Bump github.com/onsi/ginkgo/v2 from 2.22.1 to 2.22.2 (#2207)
  • Bump github.com/onsi/gomega from 1.36.1 to 1.36.2 (#2191)
  • Bump the capi group across 4 directories with 2 updates (#2188)
  • Fix FROM_K8S_VERSION variable v1.30.0 -> v1.31.2 (#2187)
  • Bump github/codeql-action from 3.27.5 to 3.27.9 (#2176)

♻️ Superseded or Reverted

(#2193)

The image for this release is: v1.9.1 Mariadb image tag is capm3-v1.9.1

Commits
  • 5e55595 Merge pull request #2215 from Nordix/bump-ipam-to-1.9.2-release1.9
  • 32b5693 Bump IPAM to 1.9.2
  • 3135b45 Merge pull request #2213 from metal3-io-bot/cherry-pick-2201-to-release-1.9
  • 0203918 Fixing IPReuse test
  • fa47499 Merge pull request #2208 from metal3-io/dependabot/go_modules/test/release-1....
  • 537c0d8 🌱 Bump github.com/onsi/ginkgo/v2 from 2.22.1 to 2.22.2 in /test
  • 1dd3d80 Merge pull request #2207 from metal3-io/dependabot/go_modules/release-1.9/git...
  • ea4aed5 🌱 Bump github.com/onsi/ginkgo/v2 from 2.22.1 to 2.22.2
  • 4303fd7 Merge pull request #2191 from metal3-io/dependabot/go_modules/api/release-1.9...
  • f1bfacd Update generated code
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/metal3-io/cluster-api-provider-metal3/api](https://github.com/metal3-io/cluster-api-provider-metal3) from 1.9.0 to 1.9.1.
- [Release notes](https://github.com/metal3-io/cluster-api-provider-metal3/releases)
- [Commits](v1.9.0...v1.9.1)

---
updated-dependencies:
- dependency-name: github.com/metal3-io/cluster-api-provider-metal3/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 8, 2025
@metal3-io-bot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 8, 2025
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@tuminoid
Copy link
Member

tuminoid commented Jan 9, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member

I believe it’s better to use a relative path to the /api folder instead of importing a specific version.
like this:

require (
    github.com/metal3-io/cluster-api-provider-metal3/api v0.0.0
)
replace github.com/metal3-io/cluster-api-provider-metal3/api => ./../api

@mquhuy Is there a specific reason we are importing a particular version of the /api module? If not, let’s update this to use the local path instead.

@tuminoid
Copy link
Member

tuminoid commented Jan 9, 2025

I believe it’s better to use a relative path to the /api folder instead of importing a specific version. like this:

require (
    github.com/metal3-io/cluster-api-provider-metal3/api v0.0.0
)
replace github.com/metal3-io/cluster-api-provider-metal3/api => ./../api

@mquhuy Is there a specific reason we are importing a particular version of the /api module? If not, let’s update this to use the local path instead.

We've discussed this before, and this is due container image build restrictions. The /api folder is outside the build context, so we must refer to it like this for now.

@tuminoid
Copy link
Member

tuminoid commented Jan 9, 2025

/retest

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@tuminoid
Copy link
Member

tuminoid commented Jan 9, 2025

/retest

@metal3-io-bot metal3-io-bot merged commit da24cf6 into main Jan 9, 2025
15 checks passed
@metal3-io-bot metal3-io-bot deleted the dependabot/go_modules/hack/fake-apiserver/main/github.com/metal3-io/cluster-api-provider-metal3/api-1.9.1 branch January 9, 2025 10:27
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.10 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants