Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Release v1.8.4 #2234

Merged
merged 1 commit into from
Jan 14, 2025
Merged

🚀 Release v1.8.4 #2234

merged 1 commit into from
Jan 14, 2025

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Jan 10, 2025 •
edited
Loading

What this PR does / why we need it: Release v1.8.4

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 10, 2025
tuminoid
tuminoid reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this generated with the new release workflow? mariadb-image tag is missing.

releasenotes/v1.8.4.md Show resolved Hide resolved
@peppi-lotta
🚀 Release v1.8.4
9d73798 
Signed-off-by: peppi-lotta <[email protected]>
@mquhuy mquhuy requested a review from tuminoid January 13, 2025 07:39
tuminoid
tuminoid reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2025
@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mquhuy
Copy link
Member

mquhuy commented Jan 13, 2025

/cc @adilGhaffarDev

kashifest
kashifest reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@metal3-io-bot metal3-io-bot merged commit c8eb5fc into metal3-io:main Jan 14, 2025
11 checks passed
@metal3-io-bot metal3-io-bot deleted the release-notes-1.8.4 branch January 14, 2025 08:15
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.10 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@tuminoid tuminoid tuminoid left review comments

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
CAPM3 - v1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@peppi-lotta @metal3-io-bot @tuminoid @mquhuy @kashifest