Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump sigs.k8s.io/kustomize/kustomize/v5 from 5.5.0 to 5.6.0 in /hack/tools #2244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 15, 2025

Bumps sigs.k8s.io/kustomize/kustomize/v5 from 5.5.0 to 5.6.0.

Release notes

Sourced from sigs.k8s.io/kustomize/kustomize/v5's releases.

kustomize/v5.6.0

Announce

This release introduces a unified internal package version (v0.19.0) across the entire kustomize repository. ref. kubernetes-sigs/kustomize#5800

Chore

#5809: fix: "edit add labels" make labels handle -f flag same as commonLabels

Dependencies

#5825: Update to latest kube-opeapi to drop govalidator dependency #5830: downgrade go-difflib and go-spew to tagged releases #5837: Update kyaml to v0.19.0 #5839: Update cmd/config to v0.19.0 #5840: Update api to v0.19.0

Commits
  • 95db4aa Merge pull request #5840 from koba1t/pinToApi
  • 07f62bd Update api to v0.19.0
  • b69e765 Merge pull request #5839 from koba1t/pinToCmdConfig
  • 8a51255 Update cmd/config to v0.19.0
  • ce667b7 Merge pull request #5837 from koba1t/pinToKyaml
  • 1b33db5 Update kyaml to v0.19.0
  • 880a7a0 add go work verification step for github actions (#5833)
  • 2867f35 downgrade go-difflib and go-spew to tagged releases (#5830)
  • 214aa2a Merge pull request #5823 from kubernetes-sigs/dependabot/go_modules/hack/gola...
  • 6f62ee7 build(deps): bump golang.org/x/crypto from 0.24.0 to 0.31.0 in /hack
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 15, 2025
@metal3-io-bot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 15, 2025
@tuminoid
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/hack/tools/main/sigs.k8s.io/kustomize/kustomize/v5-5.6.0 branch from 0b155b8 to 025e64b Compare January 17, 2025 06:36
@tuminoid
Copy link
Member

# k8s.io/code-generator/cmd/conversion-gen/generators
/home/prow/go/pkg/mod/k8s.io/[email protected]/cmd/conversion-gen/generators/conversion.go:161:72: invalid operation: signature.Parameters[2].Name != scopeName (mismatched types string and "k8s.io/gengo/v2/types".Name)
/home/prow/go/pkg/mod/k8s.io/[email protected]/cmd/conversion-gen/generators/conversion.go:165:66: invalid operation: signature.Results[0].Name != errorName (mismatched types string and "k8s.io/gengo/v2/types".Name)
/home/prow/go/pkg/mod/k8s.io/[email protected]/cmd/conversion-gen/generators/conversion.go:171:13: inType.Kind undefined (type *"k8s.io/gengo/v2/types".ParamResult has no field or method Kind)
/home/prow/go/pkg/mod/k8s.io/[email protected]/cmd/conversion-gen/generators/conversion.go:171:46: outType.Kind undefined (type *"k8s.io/gengo/v2/types".ParamResult has no field or method Kind)
/home/prow/go/pkg/mod/k8s.io/[email protected]/cmd/conversion-gen/generators/conversion.go:177:31: inType.Elem undefined (type *"k8s.io/gengo/v2/types".ParamResult has no field or method Elem)
/home/prow/go/pkg/mod/k8s.io/[email protected]/cmd/conversion-gen/generators/conversion.go:177:45: outType.Elem undefined (type *"k8s.io/gengo/v2/types".ParamResult has no field or method Elem)
/home/prow/go/pkg/mod/k8s.io/[email protected]/cmd/conversion-gen/generators/conversion.go:181:33: inType.Elem undefined (type *"k8s.io/gengo/v2/types".ParamResult has no field or method Elem)
/home/prow/go/pkg/mod/k8s.io/[email protected]/cmd/conversion-gen/generators/conversion.go:181:47: outType.Elem undefined (type *"k8s.io/gengo/v2/types".ParamResult has no field or method Elem)
make[1]: *** [Makefile:285: /home/prow/go/src/github.com/metal3-io/cluster-api-provider-metal3/hack/tools/bin/conversion-gen] Error 1

Needs manual changes.

@mquhuy mquhuy force-pushed the dependabot/go_modules/hack/tools/main/sigs.k8s.io/kustomize/kustomize/v5-5.6.0 branch from 025e64b to 8109535 Compare January 17, 2025 07:15
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2025
hack/tools/go.mod Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the dependabot/go_modules/hack/tools/main/sigs.k8s.io/kustomize/kustomize/v5-5.6.0 branch from 8109535 to 5b93b0b Compare January 17, 2025 07:17
@mquhuy
Copy link
Member

mquhuy commented Jan 17, 2025

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@mquhuy mquhuy force-pushed the dependabot/go_modules/hack/tools/main/sigs.k8s.io/kustomize/kustomize/v5-5.6.0 branch from 5b93b0b to e81ff9a Compare January 17, 2025 08:24
@tuminoid tuminoid changed the title 🌱 Bump sigs.k8s.io/kustomize/kustomize/v5 from 5.5.0 to 5.6.0 in /hack/tools 🌱 Bump sigs.k8s.io/kustomize/kustomize/v5 from 5.5.0 to 5.6.0 in /hack/tools Jan 17, 2025
@tuminoid
Copy link
Member

GH actions went missing again.

@mquhuy mquhuy force-pushed the dependabot/go_modules/hack/tools/main/sigs.k8s.io/kustomize/kustomize/v5-5.6.0 branch 2 times, most recently from 30e3c1e to d8a4d9a Compare January 17, 2025 09:01
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2025
@metal3-io-bot
Copy link
Contributor

rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mquhuy mquhuy force-pushed the dependabot/go_modules/hack/tools/main/sigs.k8s.io/kustomize/kustomize/v5-5.6.0 branch 2 times, most recently from d3d2a9e to 8f17287 Compare January 17, 2025 09:07
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2025
@mquhuy mquhuy force-pushed the dependabot/go_modules/hack/tools/main/sigs.k8s.io/kustomize/kustomize/v5-5.6.0 branch from 8f17287 to e1cca99 Compare January 17, 2025 09:08
Bumps [sigs.k8s.io/kustomize/kustomize/v5](https://github.com/kubernetes-sigs/kustomize) from 5.5.0 to 5.6.0.
- [Release notes](https://github.com/kubernetes-sigs/kustomize/releases)
- [Commits](kubernetes-sigs/kustomize@kustomize/v5.5.0...kustomize/v5.6.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/kustomize/kustomize/v5
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@mquhuy mquhuy force-pushed the dependabot/go_modules/hack/tools/main/sigs.k8s.io/kustomize/kustomize/v5-5.6.0 branch from 20a7e03 to e497120 Compare January 17, 2025 09:14
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
@metal3-io-bot
Copy link
Contributor

@dependabot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-centos-e2e-integration-test-main e497120 link true /test metal3-centos-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@metal3-io-bot
Copy link
Contributor

@dependabot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-centos-e2e-integration-test-main e497120 link true /test metal3-centos-e2e-integration-test-main

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tuminoid
Copy link
Member

Lets run tests next week when CI is more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants