Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix: pulling unused images in the middle of tests #2271

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🐛 Fix: pulling unused images in the middle of tests #2271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,23 @@ ARTIFACTS ?= $(ROOT_DIR)/_artifacts
E2E_CONF_FILE ?= $(ROOT_DIR)/test/e2e/config/e2e_conf.yaml
E2E_OUT_DIR ?= $(ROOT_DIR)/test/e2e/_out
E2E_CONF_FILE_ENVSUBST ?= $(E2E_OUT_DIR)/$(notdir $(E2E_CONF_FILE))
E2E_CONTAINERS ?= quay.io/metal3-io/cluster-api-provider-metal3 quay.io/metal3-io/baremetal-operator quay.io/metal3-io/ip-address-manager

CONTAINER_REGISTRY ?= $(REGISTRY)
CAPM3RELEASEBRANCH ?= main
IPAMRELEASEBRANCH ?= $(CAPM3RELEASEBRANCH)
BMORELEASEBRANCH ?= main

CAPM3_IMAGE ?= $(CONTAINER_REGISTRY)/cluster-api-provider-metal3:$(CAPM3RELEASEBRANCH)
IPAM_IMAGE ?= $(CONTAINER_REGISTRY)/ip-address-manager:$(IPAMRELEASEBRANCH)
BARE_METAL_OPERATOR_IMAGE ?= $(CONTAINER_REGISTRY)/baremetal-operator:$(BMORELEASEBRANCH)
E2E_CONTAINERS ?= $(CAPM3_IMAGE) $(IPAM_IMAGE) $(BARE_METAL_OPERATOR_IMAGE)

SKIP_CLEANUP ?= false
EPHEMERAL_TEST ?= false
SKIP_CREATE_MGMT_CLUSTER ?= true

## Processes e2e_conf file
.PHONY: e2e-substitutions
.PHONY: e2e-substitutions
e2e-substitutions: $(ENVSUBST)
mkdir -p $(E2E_OUT_DIR)
$(ENVSUBST) < $(E2E_CONF_FILE) > $(E2E_CONF_FILE_ENVSUBST)
Expand Down