Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add support for IRSO in e2e pipeline #950

Merged
merged 1 commit into from
Jan 21, 2025
Merged

🌱 Add support for IRSO in e2e pipeline #950

merged 1 commit into from
Jan 21, 2025

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Jan 14, 2025

This adds IRSO param for E2E pipeline

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2025
tuminoid
tuminoid reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
dtantsur
dtantsur previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mquhuy mquhuy force-pushed the mquhuy/add-support-for-irso branch from da331b4 to 5811ad6 Compare January 15, 2025 07:43
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2025
@mquhuy
Add support for IRSO in e2e pipeline
45e6642 
This adds IRSO param for E2E pipeline

Signed-off-by: Huy Mai <[email protected]>
@mquhuy mquhuy force-pushed the mquhuy/add-support-for-irso branch from 5811ad6 to 45e6642 Compare January 15, 2025 08:08
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2025
dtantsur
dtantsur reviewed Jan 15, 2025
View reviewed changes
prow/config/jobs/metal3-io/ironic-standalone-operator.yaml
@@ -48,3 +48,16 @@ presubmits:
value: "/"
image: ghcr.io/yannh/kubeconform:v0.6.7-alpine@sha256:824e0c248809e4b2da2a768b16b107cf17ada88a89ec6aa6050e566ba93ebbc6
imagePullPolicy: Always
# name: metal3-dev-env-integration-test-{image_os}-main
- name: metal3-dev-env-integration-test-ubuntu-main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these jobs set USE_IRSO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaiu USE_IRSO should be set from jjb side, haven't seen any jenkins jobs setting its own env var in prow. But I'm not a prow pro 😄 Maybe @lentzi90 could help answering this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that should come from jjb. Prow will only trigger the jobs with whatever defaults they have

@mquhuy
Copy link
Member Author

mquhuy commented Jan 15, 2025

/test metal3-ubuntu-e2e-integration-test-main

@mquhuy
Copy link
Member Author

mquhuy commented Jan 16, 2025

/retest

@mquhuy
Copy link
Member Author

mquhuy commented Jan 16, 2025

/test metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-main
We're not touching e2e integration pipeline, this does nothing.

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main
We're not touching e2e integration pipeline, this does nothing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lentzi90
lentzi90 reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
@metal3-io-bot metal3-io-bot merged commit 442cbe4 into metal3-io:main Jan 21, 2025
6 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/add-support-for-irso branch January 21, 2025 12:16
@metal3-io-bot
Copy link
Collaborator

@mquhuy: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key ironic-standalone-operator.yaml using file prow/config/jobs/metal3-io/ironic-standalone-operator.yaml

In response to this:

This adds IRSO param for E2E pipeline

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sunnatillo
Sunnatillo reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@tuminoid tuminoid tuminoid left review comments

@dtantsur dtantsur dtantsur left review comments

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mquhuy @metal3-io-bot @tuminoid @dtantsur @lentzi90 @Sunnatillo