Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add IRSO to milestoneapplier plugin config #955

Merged
merged 1 commit into from
Jan 23, 2025
Merged

add IRSO to milestoneapplier plugin config #955

merged 1 commit into from
Jan 23, 2025

Conversation

tuminoid
Copy link
Member

IRSO was missing from milestone applier config. Add it there, which makes any PR landing in main be part of the next release, which is v0.2.

@tuminoid
add IRSO to milestoneapplier plugin config
877b76a 
IRSO was missing from milestone applier config. Add it there, which
makes any PR landing in main be part of the next release, which is
v0.2.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2025
@tuminoid
Copy link
Member Author

/cc @elfosardo @Rozzii @lentzi90

@tuminoid
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lentzi90
lentzi90 reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
Rozzii
Rozzii reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@metal3-io-bot metal3-io-bot merged commit 798f600 into metal3-io:main Jan 23, 2025
5 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/add-irso-to-milestoneapplier branch January 23, 2025 12:34
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the plugins configmap in namespace prow at cluster default using the following files:

  • key plugins.yaml using file prow/config/plugins.yaml

In response to this:

IRSO was missing from milestone applier config. Add it there, which makes any PR landing in main be part of the next release, which is v0.2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@Sunnatillo Sunnatillo Awaiting requested review from Sunnatillo

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @lentzi90 @Rozzii