Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Glossarist to model V1 #22

Closed
wants to merge 1 commit into from

Conversation

HassanAkbar
Copy link
Member

Current version of metanorma-plugin-glossarist will not work with Glossarist model v2 so locking it to V1 until the code is updated.

Current version of `metanorma-plugin-glossarist` will not work with `Glossarist model v2` so locking it to V1 until the code is updated.
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I think we should have an indication of the dataset whether it is V1 or V2 and apply different routines on them?

@HassanAkbar
Copy link
Member Author

@ronaldtse Can you elaborate on this? I am not sure if I understand this correctly.
Do you mean that we should use different versions of glossarist for different models as specified by the user? Is this correct?

If yes, then I’ll have to look into it because I don’t know how to add multiple gem versions based on a condition. So, this might take some time.

@ronaldtse
Copy link
Contributor

I think the glossarist gem should support both v1 and v2 models and datasets.

We can use a separate adapter class for older versions for import and export.

@HassanAkbar
Copy link
Member Author

@ronaldtse I removed the support for Glossarist Model V1 because of our discussion geolexica/jekyll-geolexica#14 (comment),

But if it is needed I can add an adapter class to handle that as well.

@ronaldtse
Copy link
Contributor

@HassanAkbar if there are no datasets that use v1 anymore, there is no need to support it.

@HassanAkbar
Copy link
Member Author

@ronaldtse isotc204-glossary and osgeo-glossary both are in V1 format.

I'll write an adapter to read from the V1 format. But I think we do not need a writer for V1 because the new output should always be in V2, this will also make moving concepts from V1 to V2 very easy we will have to read them and output them.

What do you suggest?

@ronaldtse
Copy link
Contributor

I'll write an adapter to read from the V1 format. But I think we do not need a writer for V1 because the new output should always be in V2, this will also make moving concepts from V1 to V2 very easy we will have to read them and output them.

@HassanAkbar I agree with the approach. Thanks!

@HassanAkbar
Copy link
Member Author

@ronaldtse Closing this PR because now glossarist version 2.0.1 is backward compatible with glossarist model V1 so there is no need to lock it to V1.

@HassanAkbar HassanAkbar deleted the locking_to_glossarist_model_v1 branch November 28, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants