-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock Glossarist to model V1 #22
Conversation
Current version of `metanorma-plugin-glossarist` will not work with `Glossarist model v2` so locking it to V1 until the code is updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I think we should have an indication of the dataset whether it is V1 or V2 and apply different routines on them?
@ronaldtse Can you elaborate on this? I am not sure if I understand this correctly. If yes, then I’ll have to look into it because I don’t know how to add multiple gem versions based on a condition. So, this might take some time. |
I think the glossarist gem should support both v1 and v2 models and datasets. We can use a separate adapter class for older versions for import and export. |
@ronaldtse I removed the support for But if it is needed I can add an adapter class to handle that as well. |
@HassanAkbar if there are no datasets that use v1 anymore, there is no need to support it. |
@ronaldtse isotc204-glossary and osgeo-glossary both are in V1 format. I'll write an adapter to read from the V1 format. But I think we do not need a writer for V1 because the new output should always be in V2, this will also make moving concepts from V1 to V2 very easy we will have to read them and output them. What do you suggest? |
@HassanAkbar I agree with the approach. Thanks! |
@ronaldtse Closing this PR because now |
Current version of
metanorma-plugin-glossarist
will not work withGlossarist model v2
so locking it to V1 until the code is updated.