Cleanup.

metaskills · May 1, 2024 · 86632c9 · 86632c9
1 parent 793f2c0
commit 86632c9
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 34 deletions.
diff --git a/TODO.md b/TODO.md
diff --git a/src/experts/assistant.js b/src/experts/assistant.js
@@ -1,5 +1,5 @@
 import { openai } from "../openai.js";
-import { debug, formatToolOutputs } from "../helpers.js";
+import { debug } from "../helpers.js";
 import { Thread } from "./thread.js";
 import { Run } from "./run.js";
 
@@ -32,6 +32,7 @@ class Assistant {
   }
 
   async init() {
+    await this.beforeInit();
     if (!this.llm) return;
     this.assistant =
       (await this.findByID()) ||
@@ -62,6 +63,8 @@ class Assistant {
     return await this.askAssistant(message, threadID);
   }
 
+  async beforeInit() {}
+
   // Run Event Overrides
 
   onEvent(event) {}
@@ -82,7 +85,7 @@ class Assistant {
     }
   }
 
-  // Private
+  // Private (Ask)
 
   async askAssistant(message, threadID) {
     if (!this.llm) return;

diff --git a/src/helpers.js b/src/helpers.js
@@ -18,15 +18,4 @@ const messagesContent = (messages) => {
     .join("\n\n");
 };
 
-const formatToolOutputs = (outputs) => {
-  const result = outputs.map((item) => {
-    if (typeof item === "string") {
-      return item;
-    } else {
-      return JSON.stringify(item);
-    }
-  });
-  return result.join("\n\n");
-};
-
-export { debug, isDebug, messagesContent, formatToolOutputs };
+export { debug, isDebug, messagesContent };
diff --git a/test/experts/assistant.test.js b/test/experts/assistant.test.js
@@ -69,7 +69,7 @@ test("can configure various options", async () => {
     file: fs.createReadStream(path),
     purpose: "assistants",
   });
-  const assistant = await TestAssistant.initWithOptions({
+  const assistant = await TestAssistant.createWithOptions({
     metadata: { foo: "bar" },
     temperature: 0.5,
     top_p: 0.5,

diff --git a/test/fixtures/dataTool.js b/test/fixtures/dataTool.js
@@ -14,9 +14,8 @@ class DataTool extends Tool {
     });
   }
 
-  async init() {
+  async beforeInit() {
     await this._createDataFile();
-    await super.init();
   }
 
   async _createDataFile() {

diff --git a/test/fixtures/oddFactsAssistant.js b/test/fixtures/oddFactsAssistant.js
@@ -14,9 +14,8 @@ class OddFactsAssistant extends Assistant {
     });
   }
 
-  async init() {
+  async beforeInit() {
     await this._createFileSearch();
-    await super.init();
   }
 
   async _createFileSearch() {

diff --git a/test/fixtures/testAssistant.js b/test/fixtures/testAssistant.js
@@ -10,7 +10,7 @@ class TestAssistant extends Assistant {
     this._name = value;
   }
 
-  static async initWithOptions(options = {}) {
+  static async createWithOptions(options = {}) {
     const asst = new this(options);
     await asst.init();
     return asst;