Skip to content

Commit

Permalink
Add test for multiple float path parameters
Browse files Browse the repository at this point in the history
  • Loading branch information
RobbeSneyders committed Feb 17, 2023
1 parent 71f67a4 commit d425479
Show file tree
Hide file tree
Showing 4 changed files with 49 additions and 0 deletions.
10 changes: 10 additions & 0 deletions tests/api/test_parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,16 @@ def test_path_parameter_somefloat(simple_app, arg, result):
assert resp.data.decode('utf-8', 'replace') == f'"{result}"\n'


@pytest.mark.parametrize('arg, arg2, result', [
['-0.000000001', '0.3', 'float -1e-09, 0.3'],
])
def test_path_parameter_doublefloat(simple_app, arg, arg2, result):
assert isinstance(arg, str) # sanity check
app_client = simple_app.app.test_client()
resp = app_client.get(f'/v1.0/test-float-path/{arg}/{arg2}') # type: flask.Response
assert resp.data.decode('utf-8', 'replace') == f'"{result}"\n'


def test_path_parameter_somefloat__bad(simple_app):
# non-float values will not match Flask route
app_client = simple_app.app.test_client()
Expand Down
4 changes: 4 additions & 0 deletions tests/fakeapi/hello/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,10 @@ def test_get_somefloat(somefloat):
return f'{type(somefloat).__name__} {somefloat:g}'


def test_get_doublefloat(somefloat, someotherfloat):
return f'{type(somefloat).__name__} {somefloat:g}, {someotherfloat}'


def test_default_param(name):
return {"app_name": name}

Expand Down
18 changes: 18 additions & 0 deletions tests/fixtures/simple/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,24 @@ paths:
responses:
'200':
description: OK
'/test-float-path/{somefloat}/{someotherfloat}':
get:
summary: Test type casting of path parameter
operationId: fakeapi.hello.test_get_doublefloat
parameters:
- name: somefloat
in: path
required: true
schema:
type: number
- name: someotherfloat
in: path
required: true
schema:
type: number
responses:
'200':
description: OK
/test-default-query-parameter:
get:
summary: Test if default parameter is passed to function
Expand Down
17 changes: 17 additions & 0 deletions tests/fixtures/simple/swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,23 @@ paths:
200:
description: OK

/test-float-path/{somefloat}/{someotherfloat}:
get:
summary: Test type casting of path parameter
operationId: fakeapi.hello.test_get_doublefloat
parameters:
- name: somefloat
in: path
type: number
required: true
- name: someotherfloat
in: path
type: number
required: true
responses:
200:
description: O

/test-default-query-parameter:
get:
summary: Test if default parameter is passed to function
Expand Down

0 comments on commit d425479

Please sign in to comment.