Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added some functions to your port to get it to compile on Darwin (OSX) systems. Mainly this just involved creating a few functions you get in Linux and changing a few printf's to use the right types. All of these changes are wrapped in an #ifdef which is only defined if
__APPLE__
or__MACH__
are defined by the system. I also added an UNUSED macro which you can wrap unused vars in to deal with compiler errors.The one 'annoying' change is that clang doesn't like -pthread in the linker flags, so i had to remove this for darwin builds. Rather than put the logic to deal with this in to every demo makefile i broke it out into an include and added this file to all the makefiles instead.
After doing these things build_all.sh works perfectly on osx and all the demo programs build and run.