Fixes eclipse-jdt#1186 (possibly) - exceptions have wrong name in met…

…hod mouseover popup box Signed-off-by: Rob Stryker <[email protected]> Also-By: Mickael Istria <[email protected]>
mickaelistria · Jan 31, 2025 · 03a3b01 · 03a3b01
1 parent c5c2663
commit 03a3b01
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/javac/dom/JavacMethodBinding.java b/org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/javac/dom/JavacMethodBinding.java
@@ -313,13 +313,13 @@ private IMethod resolved(IMethod from) {
 	 * @return the key including the exception suffix
 	 */
 	private String computeKeyWithThrowsFromJavadoc(IMethod method) {
-		String[] exceptions = Arrays.stream(getExceptionTypes()).map(ITypeBinding::getKey).toArray(String[]::new);
-		if (method != null) {
-			try {
-				exceptions = method.getExceptionTypes();
-			} catch (JavaModelException ex) {
-				// ignore
-			}
+		String[] exceptions = null;
+		try {
+			exceptions = method.getExceptionTypes();
+		} catch (JavaModelException ex) {
+		}
+		if (exceptions == null || exceptions.length == 0) {
+			exceptions = Arrays.stream(getExceptionTypes()).map(ITypeBinding::getKey).toArray(String[]::new);
 		}
 		return getKey() + Arrays.stream(exceptions).map(t -> '|' + t.replace('.', '/')).collect(Collectors.joining());
 	}