-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish mediation model metadata #678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the previous messy data was actually "mediate" class. I think we have to also output the mediate object as user might expect that the actual output from mediate()
is also returned.
However, most of the data in this new metadata table is relevant for the user. So my suggestion is that
- We keep the attributes() untouched. It should include the raw mediate() output.
- We add confidence intervals (and other relevant info) to the main table
Does this sound feasible?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #678 +/- ##
==========================================
- Coverage 70.11% 69.34% -0.77%
==========================================
Files 47 47
Lines 5778 5918 +140
==========================================
+ Hits 4051 4104 +53
- Misses 1727 1814 +87 ☔ View full report in Codecov by Sentry. |
To handle the dependencies, I changed |
Hi! This PR targets the messy metadata of the getMediation output and reorganises it into a data.frame. This issue was raised in microbiome/miaViz#165.
Example: