Replace getPrevalence with addPrevalence #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antagomir
approved these changes
May 21, 2024
|
imo OK to merge |
TuomasBorman
approved these changes
May 24, 2024
|
@thpralas still some failing checks? |
|
Bioconductor devel does not still have latest changes. That is because there is a pending agglomerateByRank issue. The fixes are already merged in devel, so we have to solve the issue before pushing to Bioconductor |
|
The R CMD check warning should be solved when pushing mia current version to Bioc devel. |
|
This PR is linked to mia PR microbiome/mia#529 that was closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After mia PR microbiome/mia#529 that renamed the following functions :
getPrevalence-->addPrevalencegetPrevalentAbundance-->addPrevalentAbundanceThis PR replaces
getPrevalencewithaddPrevalencein miaViz.