Build: Fix GetLocales lint

The linter has false positives when used accross modules, so we have to ignore the lint for other modules
microg · Dec 12, 2023 · f0b15d2 · f0b15d2
1 parent a8d32be
commit f0b15d2
Show file tree

Hide file tree

Showing 8 changed files with 26 additions and 12 deletions.
diff --git a/play-services-ads-identifier/core/build.gradle b/play-services-ads-identifier/core/build.gradle
@@ -37,6 +37,6 @@ android {
     }
 
     lintOptions {
-        disable 'MissingTranslation'
+        disable 'MissingTranslation', 'GetLocales'
     }
 }
diff --git a/play-services-auth-api-phone/core/build.gradle b/play-services-auth-api-phone/core/build.gradle
@@ -39,6 +39,6 @@ android {
     }
 
     lintOptions {
-        disable 'MissingTranslation'
+        disable 'MissingTranslation', 'GetLocales'
     }
 }
diff --git a/play-services-base/core/src/main/java/org/microg/gms/common/DeviceConfiguration.java b/play-services-base/core/src/main/java/org/microg/gms/common/DeviceConfiguration.java
@@ -16,6 +16,7 @@
 
 package org.microg.gms.common;
 
+import android.annotation.SuppressLint;
 import android.app.ActivityManager;
 import android.content.Context;
 import android.content.pm.ConfigurationInfo;
@@ -39,6 +40,8 @@
 import javax.microedition.khronos.egl.EGLContext;
 import javax.microedition.khronos.egl.EGLDisplay;
 
+import static android.os.Build.VERSION.SDK_INT;
+
 public class DeviceConfiguration {
     public List<String> availableFeatures;
     public int densityDpi;
@@ -89,17 +92,28 @@ public DeviceConfiguration(Context context) {
         this.nativePlatforms = getNativePlatforms();
         widthPixels = displayMetrics.widthPixels;
         heightPixels = displayMetrics.heightPixels;
-        locales = new ArrayList<String>(Arrays.asList(context.getAssets().getLocales()));
-        for (int i = 0; i < locales.size(); i++) {
-            locales.set(i, locales.get(i).replace("-", "_"));
-        }
-        Collections.sort(locales);
+        locales = getLocales(context);
         Set<String> glExtensions = new HashSet<String>();
         addEglExtensions(glExtensions);
         this.glExtensions = new ArrayList<String>(glExtensions);
         Collections.sort(this.glExtensions);
     }
 
+    @SuppressLint("GetLocales")
+    private static List<String> getLocales(Context context) {
+        List<String> locales = new ArrayList<String>();
+        if (SDK_INT >= 21) {
+            locales.addAll(Arrays.asList(context.getAssets().getLocales()));
+        } else {
+            locales.add("en-US");
+        }
+        for (int i = 0; i < locales.size(); i++) {
+            locales.set(i, locales.get(i).replace("-", "_"));
+        }
+        Collections.sort(locales);
+        return locales;
+    }
+
     @SuppressWarnings({"deprecation", "InlinedApi"})
     private static List<String> getNativePlatforms() {
         List<String> nativePlatforms;

diff --git a/play-services-core/build.gradle b/play-services-core/build.gradle
@@ -129,7 +129,7 @@ android {
     }
 
     lintOptions {
-        disable 'MissingTranslation', 'InvalidPackage', 'BatteryLife', 'ImpliedQuantity', 'MissingQuantity', 'InvalidWakeLockTag', 'UniquePermission'
+        disable 'MissingTranslation', 'GetLocales', 'InvalidPackage', 'BatteryLife', 'ImpliedQuantity', 'MissingQuantity', 'InvalidWakeLockTag', 'UniquePermission'
     }
 
     buildTypes {

diff --git a/play-services-droidguard/core/build.gradle b/play-services-droidguard/core/build.gradle
@@ -54,7 +54,7 @@ android {
     }
 
     lintOptions {
-        disable 'MissingTranslation'
+        disable 'MissingTranslation', 'GetLocales'
     }
 
     compileOptions {

diff --git a/play-services-fido/core/build.gradle b/play-services-fido/core/build.gradle
@@ -55,7 +55,7 @@ android {
     }
 
     lintOptions {
-        disable 'MissingTranslation'
+        disable 'MissingTranslation', 'GetLocales'
     }
 
     compileOptions {

diff --git a/play-services-location/core/build.gradle b/play-services-location/core/build.gradle
@@ -46,7 +46,7 @@ android {
     }
 
     lintOptions {
-        disable 'MissingTranslation'
+        disable 'MissingTranslation', 'GetLocales'
     }
 
     flavorDimensions = ['target']

diff --git a/play-services-nearby/core/build.gradle b/play-services-nearby/core/build.gradle
@@ -53,7 +53,7 @@ android {
     }
 
     lintOptions {
-        disable 'MissingTranslation'
+        disable 'MissingTranslation', 'GetLocales'
     }
 
     compileOptions {