Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location: add SNCF/Ouigo location lookup support #2099

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

valerierx
Copy link
Contributor

@valerierx valerierx commented Nov 26, 2023

Self-explanatory. Tested with _SNCF_WIFI_INOUI.

Edit: There may be a second endpoint specifically used on Intercités night trains at www.ombord.info/api/jsonp/position/ using the same SSID as daytime Intercités, though I am unable to verify that.

Copy link
Member

@mar-v-in mar-v-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on extending support for additional networks. After all, this can only work as a collaborative community effort, as it's impossible for me to figure out the details for all networks in the world.

Also, allowing different endpoints on wi-fi networks with the same name is indeed likely to be needed in the future. I will look into adjusting the structure of the code to make this easy (especially, we can and should remember which endpoint to query based on mac address, so we won't try all endpoints for a given name again and again). For now, it's fine to focus on the more common case.

@valerierx valerierx force-pushed the master branch 2 times, most recently from 263ea3a to f164ce1 Compare December 10, 2023 00:06
@valerierx
Copy link
Contributor Author

Also, allowing different endpoints on wi-fi networks with the same name is indeed likely to be needed in the future. I will look into adjusting the structure of the code to make this easy (especially, we can and should remember which endpoint to query based on mac address, so we won't try all endpoints for a given name again and again). For now, it's fine to focus on the more common case.

Actually, I think that this endpoint isn't used on french night trains anymore, I just saw it mentioned on another github project. And these endpoints do work for 60-70% of french trains.

@mar-v-in mar-v-in merged commit 2c0d210 into microg:master Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants