add @ContentDisposition annotation for setting Content-Disposition he… #11488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaimaaeROUAI
added
the
type: improvement
yawkat
reviewed
Jan 7, 2025
| @@ -26,6 +26,8 @@ dependencies { | |||
| testImplementation(libs.micronaut.test.junit5) { | |||
| exclude(group= "io.micronaut") | |||
| } | |||
| testImplementation("io.micronaut:micronaut-http-client") | |||
yawkat
reviewed
Jan 7, 2025
yawkat
reviewed
Jan 7, 2025
| import reactor.core.publisher.Flux; | ||
|
|
||
| /** | ||
| * A filter that adds the `Content-Disposition` header to HTTP responses for specific endpoints. |
yawkat
reviewed
Jan 7, 2025
| * @return A publisher that emits the modified or unmodified HTTP response. | ||
| */ | ||
| @Override | ||
| public Publisher<MutableHttpResponse<?>> doFilter(HttpRequest<?> request, ServerFilterChain chain) { |
…tion.java Co-authored-by: Jonas Konrad <[email protected]>
yawkat
reviewed
Jan 7, 2025
| */ | ||
| @Singleton | ||
| @Filter("/**") | ||
| public class ContentDispositionFilter implements HttpServerFilter { |
There was a problem hiding this comment.
In fact I'm not sure we can have a general filter like this. It will affect performance of all controllers, even those without the annotation. Potentially this change needs to go into ResponseLifecycle instead (after #11342 )
|
I think you can simply implement |
graemerocher
requested changes
Jan 7, 2025
| */ | ||
| @Override | ||
| public Publisher<MutableHttpResponse<?>> doFilter(HttpRequest<?> request, ServerFilterChain chain) { | ||
| if (request.getPath().startsWith("/report/result")) { |
There was a problem hiding this comment.
this class is in src/main/java but seems to be hard coded to some test classes (ReportController) this doesn't seem to belong here at all. What is this PR trying to achieve?
| * Provides an endpoint to generate and download a CSV report. | ||
| */ | ||
| @Controller("/report") | ||
| public class ReportController { |
There was a problem hiding this comment.
this should not be in src/main/java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #9480