Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continue Nested HTTP Tracing Reactive Tests fail #320

Draft
wants to merge 1 commit into
base: 6.5.x
Choose a base branch
from
Draft

continue Nested HTTP Tracing Reactive Tests fail #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tracing-jaeger/src/test/groovy/io/micronaut/tracing/jaeger/HttpTracingExclusionSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import io.micronaut.http.client.exceptions.HttpClientResponseException
import io.micronaut.runtime.server.EmbeddedServer
import io.opentracing.Tracer
import spock.lang.AutoCleanup
import spock.lang.PendingFeature
import spock.lang.Specification
import spock.util.concurrent.PollingConditions

Expand Down Expand Up @@ -513,7 +512,6 @@ class HttpTracingExclusionSpec extends Specification {
}
}

@PendingFeature
void 'test continue nested HTTP tracing - reactive'() {
when:
HttpResponse<String> response = client.toBlocking().exchange('/traced/nestedReactive/John', String)
Expand Down
3 changes: 0 additions & 3 deletions tracing-jaeger/src/test/groovy/io/micronaut/tracing/jaeger/HttpTracingSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,13 @@ import io.micronaut.http.client.exceptions.HttpClientResponseException
import io.micronaut.runtime.server.EmbeddedServer
import io.micronaut.scheduling.annotation.ExecuteOn
import io.micronaut.tracing.annotation.ContinueSpan
import io.micronaut.tracing.annotation.NewSpan
import io.opentracing.Tracer
import jakarta.inject.Inject
import org.reactivestreams.Publisher
import reactor.core.publisher.Flux
import reactor.core.publisher.Mono
import reactor.core.scheduler.Schedulers
import spock.lang.AutoCleanup
import spock.lang.PendingFeature
import spock.lang.Specification
import spock.util.concurrent.PollingConditions

Expand Down Expand Up @@ -627,7 +625,6 @@ class HttpTracingSpec extends Specification {
}
}

@PendingFeature
void 'test continue nested HTTP tracing - reactive'() {
when:
HttpResponse<String> response = client.toBlocking().exchange('/traced/nestedReactive/John', String)
Expand Down