-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logs #158
Add logs #158
Conversation
e6bacd7
to
cf936a5
Compare
f0b7731
to
402a047
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main question we need to consider is whether there is any need for the logs API to be exposed to applications. The alternative is that we could just require that runtimes that support MP Telemetry provide a way to route the runtime and app's logs to OpenTelemetry.
Like @donbourne noted, this API is not really intended for end users. Rather the runtimes should assure that their application and system logs are exported over appropriate OpenTelemetry channel. For that we would need:
Then the reasonable requirement would be that application's logs capture reasonable context information and other telemetry attributes -- the feature that could actually be implemented on top of |
Is JUL the one every runtime supports? |
I believe I have addressed all of your comments @donbourne @pdudits @brunobat . Please re-review and approve or add more comments. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - just one very minor comment.
No description provided.