Add logs TCK #172
Merged
Add logs TCK #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasmin-aumeeruddy
force-pushed
the
logs-tck
branch
from
61837e9 to
4dc3ad3
Compare
yasmin-aumeeruddy
force-pushed
the
logs-tck
branch
from
3f52d6b to
0121a43
Compare
pdudits
approved these changes
Apr 29, 2024
Emily-Jiang
reviewed
Apr 29, 2024
| // limitations under the License. | ||
| // | ||
|
|
||
| = MicroProfile Telemetry logs TCK |
There was a problem hiding this comment.
Just a note here: we will look at the overall readme so that we don't duplicate info for the three pillars. I will raise an issue to lift the common piece later.
Emily-Jiang
reviewed
Apr 29, 2024
Emily-Jiang
reviewed
Apr 29, 2024
fmhwong
reviewed
Apr 30, 2024
| julLogger.info("A JUL log message"); | ||
| System.out.println(openTelemetry); | ||
| Assert.assertEquals(memoryExporter.getFinishedLogRecordItems(1).get(0).getBody(), "A JUL log message"); | ||
| } |
There was a problem hiding this comment.
Can we also verify the severity?
There was a problem hiding this comment.
I will make an issue to do this in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.