Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to collect runtime telemetry #180

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Add a way to collect runtime telemetry #180

merged 5 commits into from
Jun 11, 2024

Conversation

donbourne
Copy link
Contributor

@donbourne donbourne commented Jun 5, 2024 •
edited
Loading

Fixes #169

@donbourne
Copy link
Contributor Author

@pdudits / @brunobat , would either of you be able to review this?

@donbourne donbourne requested review from brunobat and pdudits June 6, 2024 14:39
tjquinno
tjquinno reviewed Jun 10, 2024
View reviewed changes
Copy link

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of requested clarifications.

spec/src/main/asciidoc/integration.adoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/integration.adoc Outdated Show resolved Hide resolved
@donbourne donbourne mentioned this pull request Jun 11, 2024
Closed
@donbourne donbourne merged commit a2e5f7d into microprofile:main Jun 11, 2024
3 checks passed
@donbourne donbourne deleted the issue_169 branch June 11, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjquinno tjquinno tjquinno left review comments

@pdudits pdudits pdudits approved these changes

@brunobat brunobat Awaiting requested review from brunobat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a way to specify a server otel config independently of app otel config
3 participants
@donbourne @pdudits @tjquinno